Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract BelongsToCollection struct #71

Merged
merged 11 commits into from
Dec 10, 2024

Conversation

maddox
Copy link
Contributor

@maddox maddox commented Nov 19, 2024

Description

  • This extracts the BelongsToCollection struct to a type so it can be used easier elsewhere.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Nuxij
Copy link

Nuxij commented Dec 1, 2024

Crack on lad!

@cyruzin cyruzin merged commit 9ca65b6 into cyruzin:master Dec 10, 2024
2 of 3 checks passed
@cyruzin
Copy link
Owner

cyruzin commented Dec 10, 2024

@maddox thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants