[0.29] implement the depfile command-line option for the "cython" tool #4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor cythonize depfile support to be reusable We would like to use it in the frontend for the cython tool as well. Pull it out of the main loop and make it a utility function. * fix depfiles emitting unusable relative paths The paths for files in the source tree are relative instead of absolute. This is not inherently a problem, but they are relative to the containing directory of the source code file but the program that parses these files (make, ninja) computes filenames relative to its working directory, not relative to the source file. Likewise, the final output file had its entire path component trimmed, leaving just a bare filename. Make this actually work by computing all relative paths relative to the current working directory of the cython process itself. When invoked by a build system, this will be the same directory the build system expects files to be based on. This has the obvious drawback of requiring a sensible work directory (i.e. you can't "just run" cython next to the sources), but it's still a reasonable thing to assume and we already make that assumption in other places. (cherry picked from commit 820b444)
Fix a broken test that seems to be different on 0.29 vs. master?
eli-schwartz
force-pushed
the
depfile-singletranspile-0.29
branch
from
d9e3817
to
f123169
Compare
|
Looks good. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #4916
I'm not sure I understand what's up with the second commit here.