Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add versioned artifact build action #373

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

kenibrewer
Copy link
Member

@kenibrewer kenibrewer commented Feb 20, 2024

Description

This adds a versioned code artifact to the ci pipeline that can be used during other actions and in Github releases.

Closes #369

What is the nature of your change?

  • Enhancement (adds functionality).

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@kenibrewer kenibrewer force-pushed the build/build-versioned-artifact branch from 48ca109 to 511ec3f Compare February 21, 2024 12:08
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (cfd0852) to head (9a2af80).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files          56       56           
  Lines        3187     3187           
=======================================
  Hits         3028     3028           
  Misses        159      159           
Flag Coverage Δ
unittests 95.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kenibrewer kenibrewer force-pushed the build/build-versioned-artifact branch from 511ec3f to bc90120 Compare February 21, 2024 14:09
@kenibrewer kenibrewer marked this pull request as ready for review February 21, 2024 14:10
@kenibrewer kenibrewer self-assigned this Feb 21, 2024
@kenibrewer kenibrewer requested a review from d33bs February 21, 2024 14:10
@kenibrewer kenibrewer force-pushed the build/build-versioned-artifact branch from bc90120 to de1db03 Compare February 21, 2024 14:12
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat to see this, nice work! I left a few comments up for your consideration. Please don't hesitate to let me know if you have any questions / concerns.

.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
.github/workflows/integration-test.yml Show resolved Hide resolved
.github/workflows/integration-test.yml Show resolved Hide resolved
.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
.github/workflows/integration-test.yml Show resolved Hide resolved
This adds a versioned code artifact to the ci pipeline that can be used during other actions and in Github releases.

Closes cytomining#369
Co-authored-by: Dave Bunten <d33bs@noreply.users.github.com>
@kenibrewer kenibrewer force-pushed the build/build-versioned-artifact branch from de1db03 to 014bfca Compare February 21, 2024 23:04
@kenibrewer kenibrewer requested a review from d33bs February 21, 2024 23:06
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kenibrewer for the responses and changes!

@kenibrewer kenibrewer merged commit b039ade into cytomining:main Feb 24, 2024
10 checks passed
@kenibrewer kenibrewer deleted the build/build-versioned-artifact branch February 24, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FeatureRequest: Add build artifacts for CI/CD pipeline
3 participants