Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-1955 Add AppVersionOrderRequest schema and docs #88

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

psarando
Copy link
Member

This PR will add the AppVersionOrderRequest schema and docs.

The AppVersionOrderRequest expects the app versions to be in descending order, with the newest (or latest) first, since that is also the way they are listed in the app details and listing endpoints.

Copy link
Member

@ianmcorvidae ianmcorvidae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess we're allowing the :version key but setting it optional since it won't be used by the endpoint in the apps PR. Seems fine, in any case.

@psarando
Copy link
Member Author

LGTM. I guess we're allowing the :version key but setting it optional since it won't be used by the endpoint in the apps PR. Seems fine, in any case.

Right, sometimes it's easier for the UI to reuse the same format as what it gets from a GET endpoint in a POST/PUT endpoint, but the :version labels are not needed for the reordering update.

@psarando psarando merged commit 46a967e into cyverse-de:main Oct 18, 2024
2 checks passed
@psarando
Copy link
Member Author

Thanks for the reviews! 👍

@psarando psarando deleted the CORE-1955-app-ver-reorder branch October 18, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants