This repository has been archived by the owner on Sep 12, 2022. It is now read-only.
Simplify SEND_EMAILS and DEBUG variables #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both troposphere and atmosphere have a global debug, they now have the same name. They now both default to False.
SEND_EMAILS used to be derived from another variables. This is evil at large, because it makes configuration more difficult to reason about.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SEND_EMAILS used to be derived from another variables, which makes configuration more difficult to reason about.
Both troposphere and atmosphere have a global debug, they now have the same name. They now both default to False (used to have different defaults).
See cyverse/atmosphere#649
Checklist before merging Pull Requests