-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Úkol 2 - Jozef Liška #18
Open
JFox-sk
wants to merge
4
commits into
czcodecamp:master
Choose a base branch
from
JFox-sk:strankovanie
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,27 @@ | ||
{% for product in products %} | ||
<div class="col-sm-4 col-lg-4 col-md-4"> | ||
<a href="{{ path("product_detail", {"slug": product.slug }) }}"> | ||
<div class="thumbnail"> | ||
<img src="{{ product.image }}" alt="{{ product.title }}"> | ||
<div class="caption"> | ||
<h4 class="pull-right">{{ product.price }} Kč</h4> | ||
</h4> | ||
<p>{{ product.title }}</p> | ||
<p> | ||
Sort by: | ||
{{ knp_pagination_sortable(pagination, 'Title', 'p.title') }} | ||
{{ knp_pagination_sortable(pagination, 'Rank', 'p.rank') }} | ||
</p> | ||
|
||
<div class="clearfix"> | ||
{% for product in pagination %} | ||
<div class="col-sm-4 col-lg-4 col-md-4"> | ||
<a href="{{ path("product_detail", {"slug": product.slug }) }}"> | ||
<div class="thumbnail"> | ||
<img src="{{ product.image }}" alt="{{ product.title }}"> | ||
<div class="caption"> | ||
<h4 class="pull-right">{{ product.price }} Kč</h4> | ||
</h4> | ||
<p>{{ product.title }}</p> | ||
</div> | ||
</div> | ||
</div> | ||
</a> | ||
</div> | ||
{% endfor %} | ||
</a> | ||
</div> | ||
{% endfor %} | ||
</div> | ||
|
||
{# display navigation #} | ||
<p> | ||
{{ knp_pagination_render(pagination) }} | ||
</p> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# CodeCamp project | ||
|
||
## Used bundle | ||
|
||
### SimplePaginationBundle | ||
Pagination | ||
https://packagist.org/packages/knplabs/knp-paginator-bundle | ||
https://github.com/KnpLabs/KnpPaginatorBundle |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tento blok DQL kódu je takmer totožný s ProductRepository->findByCategory() s tým rozdielom, že KnpPaginatorBundle to vyžaduje bez getResult() /takže som tu nemohol priamo použiť túto metódu/.
Vznikla mi tu však duplicita, tak by ma zaujímalo, či je nejaký best practice ako to presunúť do ProductRepository s tým aby som mal k dispozícií metódu bez a zároveň s getResult(). Samozrejme, napadajú ma možnosti ako to je možné spraviť, ale skôr ma zaujíma to, čo je osvedčené z praxe.
Vďaka.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uvažuješ správně, určitě pokud je jeden kód duplikovaný, tak má cenu ho dát dohromady. Můžeš si tedy vytvořit metodu, která ten dotaz staví a ve findByCategory vrátit getResult nad jejím výsledkem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jo souhlas. Když je podíváš na ukázkové řešní v masteru, tak podobný problém jsem tam řešil já. Může to být ukázkové řešení. Nicméně nelíbí se mi, protože je tam porušený jeden z pricipů SOLID. Ale to vysvětlím.