Fix dynamic label regex parsing behaviour #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czerwonk
requested changes
Mar 4, 2022
|
Thanks for contributing! 🙂 |
|
Hi, I think this should warrant a release as 0.9.14 is not usable with -config.ignore-targets=true without also disabling dynamic interface labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to fix !163. Basically introduces additional constraints for user supplied regexes and ensures that at least the default regex is loaded in all cases.
If there's any feedback for the code it's more than welcome since I'm a go novice.
Also clarifies the README.md a bit.