Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect metrics on the IS-IS adjacency state #194

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

mirceaulinic
Copy link
Contributor

@mirceaulinic mirceaulinic commented Jul 22, 2022

The current IS-IS metrics only provide the total counters, i.e., number
of adjacencies and how many are up. This is great for a dashboard-like
approach, but insufficient when you need to look into a more granular
per-adjacency, for example for alerting.
Adding a new junos_isis_adjacency_state metrics family that provide
the adjacency state.
Closes #113.

mirceaulinic and others added 3 commits July 22, 2022 14:14
The current IS-IS metrics only provide the total counters, i.e., number
of adjacencies and how many are up. This is great for a dashboard-like
approach, but insufficient when you need to look into a more granular
per-adjacency, for example for alerting.
Adding a new ``junos_isis_adjacency_state`` metrics family that provide
the adjacency state.
@czerwonk czerwonk self-requested a review August 8, 2022 11:14
Copy link
Owner

@czerwonk czerwonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czerwonk czerwonk merged commit 2dde172 into czerwonk:master Aug 8, 2022
@czerwonk
Copy link
Owner

czerwonk commented Aug 8, 2022

Thanks for contributing! :)

@mirceaulinic mirceaulinic deleted the isis-adj-state branch August 8, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISIS adjecency
2 participants