Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrape license information #214

Merged
merged 10 commits into from
Jul 5, 2023
Merged

Conversation

fstolba
Copy link
Contributor

@fstolba fstolba commented Jun 14, 2023

This PR enables scraping license information (name of the license, amount of seats, time to expiry if applicable) into Prometheus.

@czerwonk czerwonk marked this pull request as ready for review June 14, 2023 11:33
@czerwonk czerwonk self-requested a review as a code owner June 14, 2023 11:33
@czerwonk czerwonk requested review from czerwonk and removed request for czerwonk June 14, 2023 11:33
@fstolba fstolba marked this pull request as draft June 14, 2023 11:37
pkg/features/system/collector.go Outdated Show resolved Hide resolved
pkg/features/system/collector.go Outdated Show resolved Hide resolved
@czerwonk
Copy link
Owner

Nice idea, thanks. Looking forward for the final request

@fstolba fstolba marked this pull request as ready for review July 4, 2023 01:02
@fstolba
Copy link
Contributor Author

fstolba commented Jul 4, 2023

It took me a while to get to but the rebase is now done. Also @czerwonk, thx for your suggestions, both implemented.
If there's something else to improve let me know (Go novice here), otherwise happy to have this merged upstream.

@fstolba fstolba requested a review from czerwonk July 4, 2023 07:46
Copy link
Owner

@czerwonk czerwonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czerwonk czerwonk merged commit f43fe9e into czerwonk:main Jul 5, 2023
@czerwonk
Copy link
Owner

czerwonk commented Jul 5, 2023

Thanks for your contribution! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants