handle platforms that don't support show system buffers command #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Juniper ACX platform does not suppoort
show system buffers
command, so the system collector crashed:It's still nice to get other metrics (mainly
os_version
) that the system collector provides so I made a patch that won't crash if buffers command does not exist.I've looked at
pkg/features/environment/collector.go
how it handles possible non existing commandshow chassis environment satellite
and made a similar change in system collector.