BGP: Implement dynamic labels from descriptions #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good so far. I like the new approach and would love to see it for interface metrics as well. In my opinion the naming of the interfacelabels package and its types do not fit any more. We can either rename it within this change to prevent using misleading naming in master (trade-off: more complex MR) or do the renaming prior to changing the interface description logic. |
|
I'm happy to follow up today with a cleanup after we merge this. |
This was referenced Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing support for dynamic labels from descriptions for BGP related metrics.
This implementation does not use any state. Unlike the implementation of dynamic labels for interface descriptions.
Shall I adjust the implementation for interface metrics too?