Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: chart fixes and improvements #259

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Conversation

crabique
Copy link
Contributor

@crabique crabique commented Nov 7, 2024

Hello!

Thanks for the great exporter, I was very glad to see it already had a Helm chart.

This PR includes some fixes and improvements that make it easier to use without forking or applying Kustomize patches.

  • fix broken ServiceMonitor
  • add support for defining container extraVolumes and extraVolumeMounts:
    • required for reading a key off an externally managed secret (e.g. ExternalSecrets operator)
  • add support for defining Deployment annotations:
    • required for Reloader controller integration to automatically restart the pods when a referenced Secret changes
  • update the existing pod reload mechanism to also react to changes in the SSH key supplied in values.yaml
  • bump chart version and exporter image (it is currently lagging two releases behind)
  • fix various typos and chart lint problems
  • update chart README with new features

Please let me know if you have any questions regarding any of the changes.

Signed-off-by: crabique <crabique@users.noreply.github.com>
…tart pod upon SSH key change too

Signed-off-by: crabique <crabique@users.noreply.github.com>
Signed-off-by: crabique <crabique@users.noreply.github.com>
Signed-off-by: crabique <crabique@users.noreply.github.com>
Signed-off-by: crabique <crabique@users.noreply.github.com>
@crabique crabique closed this Nov 7, 2024
@crabique crabique reopened this Nov 7, 2024
@czerwonk czerwonk merged commit 47819ec into czerwonk:main Nov 11, 2024
3 checks passed
@crabique crabique deleted the fix/helm-chart branch November 11, 2024 15:08
@crabique
Copy link
Contributor Author

Thanks for the merge! I didn't expect this to be tagged 0.12.5 as is 😄

This means the exporter image in the chart defaults of 0.12.5 is still 0.12.4, is this something expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants