Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for keywords does not violate with pre-defined keys on 'dever init' #27

Closed
czprz opened this issue Jan 23, 2022 · 0 comments · Fixed by #30
Closed

Add check for keywords does not violate with pre-defined keys on 'dever init' #27

czprz opened this issue Jan 23, 2022 · 0 comments · Fixed by #30
Assignees
@czprz
Labels
enhancement New feature or request
Milestone
0.9.0

Comments

@czprz
Copy link
Owner

czprz commented Jan 23, 2022 •
edited
Loading

Check that 'init', 'list' and 'config' is not a keyword within projects found by 'dever init'. As these keys cannot be used.

Add logic in 'dever init' to not include dever.json which violates pre-defined keys.
Add 'validate' option to only check keywords
@czprz czprz added the enhancement New feature or request label Jan 23, 2022
@czprz czprz added this to the 0.9.0 milestone Jan 23, 2022
@czprz czprz modified the milestones: 0.9.0, 0.8.0 Jan 31, 2022
@czprz czprz self-assigned this Jan 31, 2022
czprz added a commit that referenced this issue Jan 31, 2022
@czprz
#27 Added support for not adding projects to dever_config.json when k…
902a21b 
…eywords conflict with pre-defined keys
@czprz czprz mentioned this issue Jan 31, 2022
Merged
czprz added a commit that referenced this issue Feb 6, 2022
@czprz
#27 Added initial structure for validate command
d22135c
czprz added a commit that referenced this issue Feb 6, 2022
@czprz
#27 Removed unused file
08c061f 
+ Removed console message when project cannot be found. As this should not be part of the config handler
czprz added a commit that referenced this issue Feb 6, 2022
@czprz
#27 Incremented version
0fe3dad
czprz added a commit that referenced this issue Feb 6, 2022
@czprz
#27 Added helper for config validation
66beae8 
+ Added new simple implementation of dever.json validate command
+ Created constant helper to have a central location for predefined keys
czprz added a commit that referenced this issue Feb 6, 2022
@czprz
#27 Fixed issue with projects with conflicting keywords would not be …
fe35559 
…removed from dever_config.json
czprz added a commit that referenced this issue Feb 6, 2022
@czprz
#27 Fixed issue with keywords check not being case-sensitive
8d3864a
czprz added a commit that referenced this issue Feb 6, 2022
@czprz
#27 Moved the message for not supported version of dever.json
a17a573
czprz added a commit that referenced this issue Feb 6, 2022
@czprz
#27 Added validate commands to README
752115a
czprz added a commit that referenced this issue Feb 6, 2022
@czprz
Merge pull request #30 from czprz/27_add_keywords_check
b18f1bf 
#27 Ensure project keywords does not conflict with pre-defined keys
@czprz czprz closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czprz czprz

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

#27 Ensure project keywords does not conflict with pre-defined keys czprz/dever
1 participant
@czprz