Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggest] Move username and password definitions to dever.json instead of having them hardcoded #50

Closed
czprz opened this issue Mar 29, 2022 · 0 comments · Fixed by #51
Closed

[Suggest] Move username and password definitions to dever.json instead of having them hardcoded #50

czprz opened this issue Mar 29, 2022 · 0 comments · Fixed by #51
Labels
Suggestion Idea/Feature suggestion
Milestone
0.10.0

Comments

@czprz
Copy link
Owner

czprz commented Mar 29, 2022

Is your feature request related to a problem? Please describe.
Username and password for mssql should not be hardcoded but defined in the environment execution to make it more flexible

Describe the solution you'd like
Add new properties for username and password for when using type mssql
@czprz czprz added the Suggestion Idea/Feature suggestion label Mar 29, 2022
@czprz czprz added this to the 1.0.0 milestone Mar 29, 2022
czprz added a commit that referenced this issue Mar 29, 2022
@czprz
#50 Major refactoring of mssql helper to align with other implementat…
d6a002a 
…ions

+ Added passing of sql object which includes user/pass to remove hardcoded
@czprz czprz mentioned this issue Mar 29, 2022
Merged
czprz added a commit that referenced this issue Apr 12, 2022
@czprz
#50 Minor renaming
1463047
czprz added a commit that referenced this issue Apr 12, 2022
@czprz
#50 Added support for creating databases and tables
337185a
czprz added a commit that referenced this issue Apr 12, 2022
@czprz
#50 Added support for creating database, table and inserting data thr…
5d71c52 
…ough usage of insert option
czprz added a commit that referenced this issue Apr 12, 2022
@czprz
#50 Fixed issue with being able to create database, table and insert …
79d60b2 
…all in one entry
czprz added a commit that referenced this issue Apr 12, 2022
@czprz
#50 Improved message when inserting mssql
01ef7c7
@czprz czprz closed this as completed in #51 Apr 12, 2022
czprz added a commit that referenced this issue Apr 12, 2022
@czprz
Merge pull request #51 from czprz/50-suggest-move-username-and-passwo…
07b2d14 
…rd-definitions-to-deverjson-instead-of-having-them-hardcoded

#50 Refactoring and removal of hardcoded userpass for mssql execution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Suggestion Idea/Feature suggestion
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

#50 Refactoring and removal of hardcoded userpass for mssql execution czprz/dever
1 participant
@czprz