Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on exit when closing app immediately during initial loading #2 #455

Closed
cztomczak opened this issue Aug 17, 2018 · 1 comment
Closed
Labels
Milestone

Comments

@cztomczak
Copy link
Owner

cztomczak commented Aug 17, 2018

This is a different issue from #454. This is not a Python exception, but a crash in CPython. It is hard to reproduce. Earlier I've reproduced it multiple times when loading Google website, but now I can't. I'm also trying with https://cnn.com/ (which has a lot of frames and content), but also no luck at the moment.

During the crash the last log messages were (CefShutdown not called):

[0817/175818.046:INFO:cef_log.cpp(8)] [Browser process] V8ContextHandler_OnContextCreated()

[0817/175818.124:INFO:cef_log.cpp(8)] [Browser process] LifespanHandler_OnBeforeClose

[0817/175818.124:INFO:cef_log.cpp(8)] [Browser process] del g_pyFrames[1#2]

[0817/175818.125:INFO:cef_log.cpp(8)] [Browser process] del g_pyBrowsers[1]

[0817/175818.128:INFO:cef_log.cpp(8)] [Browser process] GetResourceHandler: Browser was already globally unref
erenced, a new incomplete instance is created, browser id=1

When debugging issues with cookies not flushed to disk (#365), I noticed that after browser is closed there are still a few callbacks being executed from CefRequestHandler: GetResourceHandler, GetCookieManager and OnBeforeResourceLoad. I have an idea to check if browser is already closed and in such case do not execute any code in these callbacks. Check with such code:

        if browserId in g_unreferenced_browsers \
            or browserId in g_closed_browsers:
@cztomczak
Copy link
Owner Author

Posibly fixed in commit a276fd8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant