Introduce interface mailfilter.Trx and a testing implementation testtrx.Trx #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion testtrx.Trx With this new testtrx.Trx users of the mailfilter milter abstraction can easily write unit tests for their decision function. before this refactoring the decision function could not easily be unit tested because generating mailfilter.Transaction structs was not possible outside of this library. BREAKING CHANGE: the mailfilter signatures changed significantly because we now pass a Trx interface to the decision function instead of a Transaction struct. The changes library users need to do are mostly calling methods instead of accessing public fields of the transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this new testtrx.Trx users of the mailfilter milter abstraction can easily write unit tests for their decision function. before this refactoring the decision function could not easily be unit tested because generating mailfilter.Transaction structs was not possible outside of this library.
BREAKING CHANGE: the mailfilter signatures changed significantly because we now pass a Trx interface to the decision function instead of a Transaction struct. The changes library users need to do are mostly calling methods instead of accessing public fields of the transaction.