Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update env_logger to 0.11 #41

Merged
merged 2 commits into from
Jan 25, 2024
Merged

update env_logger to 0.11 #41

merged 2 commits into from
Jan 25, 2024

Conversation

yanns
Copy link
Contributor

@yanns yanns commented Jan 24, 2024

@yanns yanns force-pushed the update_env_logger branch from 2ccffe1 to 760fb88 Compare January 24, 2024 14:43
@d-e-s-o d-e-s-o merged commit 508619f into d-e-s-o:main Jan 25, 2024
6 checks passed
@d-e-s-o
Copy link
Owner

d-e-s-o commented Jan 25, 2024

Thanks

@yanns yanns deleted the update_env_logger branch January 25, 2024 13:43
@yanns
Copy link
Contributor Author

yanns commented Jan 29, 2024

@d-e-s-o it'd be great to have a release with this, so that we can update env_logger in our applications.

@d-e-s-o
Copy link
Owner

d-e-s-o commented Jan 30, 2024

@d-e-s-o it'd be great to have a release with this, so that we can update env_logger in our applications.

I'd rather wait some more. The crate doesn't have a formal MSRV policy right now, but N-5 is the bare minimum from my point of view. I'd prefer N-6 or "higher". Why is it so important that this crate uses env_logger 0.11?

@yanns
Copy link
Contributor Author

yanns commented Jan 30, 2024

I had this error when trying to update env_logger:

Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path Cargo.toml --package env_logger@0.10.2 --precise 0.11.1
    Updating crates.io index
error: failed to select a version for the requirement `env_logger = "^0.10"`
candidate versions found which didn't match: 0.11.1
location searched: crates.io index
required by package `test-log v0.2.14`
    ... which satisfies dependency `test-log = "^0.2"` (locked to 0.2.14) of package `reference_service v0.1.0 (/tmp/renovate/repos/github/commercetools/reference_service)`
perhaps a crate was updated and forgotten to be re-vendored?

It's not completely blocking as I can still update the dependency though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants