New flash interface review #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missing bits and pieces, spelling, etc
|
Maybe I missed something in the aftermath of the switch to mmap (useless casting), but it worked with/without Valgrind and with/without [existing] files. |
LudwigKnuepfer
force-pushed
the
new_flash_interface-review
branch
from
34e340e to
9bab35e
Compare
LudwigKnuepfer
force-pushed
the
new_flash_interface-review
branch
from
842b6fe to
9706d25
Compare
| #include "debug.h" | ||
|
|
||
| #define FLASH_ERROR_SIMULATION (1) |
There was a problem hiding this comment.
Later i plan implement an error simulation. I use this or an similar define to switch this feature on.
There was a problem hiding this comment.
I assumed as much, but I suggest to keep it out for now. It has no benefit unless there is an implementation using it.
There was a problem hiding this comment.
I don't insist on this commit though, I left it as a separate commit on purpose ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.