-
-
Notifications
You must be signed in to change notification settings - Fork 187
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
emacs-29: fix native comp on intel with std env
- Loading branch information
1 parent
edb5b25
commit 3a61eae
Showing
2 changed files
with
27 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
From ccf4835f5dadbbe2a0c41e29c88fb37029209b42 Mon Sep 17 00:00:00 2001 | ||
From: Boris Buliga <boris@d12frosted.io> | ||
Date: Thu, 28 Apr 2022 18:22:13 +0300 | ||
Subject: [PATCH] fix MAC_LIBS inference on Intel | ||
|
||
--- | ||
configure.ac | 3 +-- | ||
1 file changed, 1 insertion(+), 2 deletions(-) | ||
|
||
diff --git a/configure.ac b/configure.ac | ||
index 7c8638a471..dcbb25c063 100644 | ||
--- a/configure.ac | ||
+++ b/configure.ac | ||
@@ -4125,8 +4125,7 @@ if test "${with_native_compilation}" != "no"; then | ||
if test -n "`$BREW --prefix --installed libgccjit 2>/dev/null`"; then | ||
MAC_CFLAGS="-I$(dirname $($BREW ls -v libgccjit | \ | ||
grep libgccjit.h))" | ||
- MAC_LIBS="-L$(dirname $($BREW ls -v libgccjit| \ | ||
- grep libgccjit.so\$))" | ||
+ MAC_LIBS="-L$(dirname $($BREW ls -v libgccjit | grep libgccjit.dylib\$ || $BREW ls -v libgccjit | grep libgccjit.so\$))" | ||
fi | ||
fi | ||
|
||
-- | ||
2.35.1 | ||
|
3a61eae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d12frosted just curious what does this do or solve? (just learning)
3a61eae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsmestad see #455 :) Some explanations of this 'quick fix' are here - #455 (comment) Another quick option would be just removing these
brew
related lines as they were skipped previously anyways. Once I have more time I will try to come with better solution than this.3a61eae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsmestad turns out Emacs upstream took the same approach, but with better shell-fu - emacs-mirror/emacs@faa29fa