This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Update native-docker.md #1076
Merged
Update native-docker.md #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a comma after the command line option url.
|
Thanks @gomes! Do you mind wrapping so line length matches the rest of the file? |
Wrapping, so the line length will matches the rest of the file
|
Done @lingmann ;) |
| @@ -44,7 +44,8 @@ Docker version 1.0.0 or later installed on each slave node. | |||
|
|
|||
| ### Configure marathon | |||
|
|
|||
| 1. Increase the marathon [command line option]({{ site.baseurl }}/docs/command-line-flags.html") `--task_launch_timeout` to at least the executor timeout you set on your slaves in the previous step. | |||
| 1. Increase the marathon [command line option]({{ site.baseurl }}/docs/command-line-flags.html) | |||
| `--task_launch_timeout` to at least the executor timeout you set on your slaves in the previous step. | |||
There was a problem hiding this comment.
We just merged a PR (#1079) that increases the timeout to 5 minutes. It might also be worth noting that the time unit for this option is ms, so 300000 means five minutes.
Inform that timeout has to be set in milliseconds
|
@ConnorDoyle I did a simple change to add it |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a comma after the command line option url.