687 expose recent scheduling decisions #1130
Conversation
This creates a kv-store for data about declined offers for apps. If an app’s resource requirements cannot be supplied by the current system, there should eventually be some notification back to the executor. Note: Manually adding event types to a bucket style method isn’t fun.
| def provideTaskOffersDeclinedRepository( | ||
| state: State, | ||
| conf: MarathonConf, | ||
| registry: MetricRegistry): TaskOffersDeclinedRepository = { |
There was a problem hiding this comment.
These parameters are unused, please remove them.
|
Thanks for your contribution. Please see my comments. Could you also please add an endpoint to retrieve the data and add it to the docs? And please squash all this into a single commit, thanks! |
| case (task, ports) => | ||
| val taskBuilder = task.toBuilder | ||
| taskBuilder.build -> ports | ||
| builder.buildIfMatches(offer) match { |
There was a problem hiding this comment.
It looks like this pattern match doesn't do anything. In both cases, the result (or the equivalent) of the call to buildIfMatches is returned. Why not just return that value instead?
|
This PR addresses #937. |
|
@abhay-agarwal, this needs to be rebased on |
|
@abhay-agarwal, do you plan to finish this up? We'd love to include this feature in 0.8.2 if possible. |
|
I hadn't looked at this since the coding challenge. I think I could do a better job, but it would be a context-switch that i'm not ready for pre Q1 release! |
|
Closing this for now, feel free to update and re-open. |
This creates a kv-store for data about declined offers for apps. If an
app’s resource requirements cannot be supplied by the current system,
there should eventually be some notification back to the executor.
Note: Manually adding event types to a bucket style method isn’t fun.