This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Override Timestamp hashCode for consistent hashing #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timestamp's hashCode was based on the parameter dataTime which might have a timezone != UTC. The consequence: val t = Timestamp.now t.hashCode != Timestamp(t.toString).hashCode This patch overrides hashCode to use the UTC normalized time variable of the Timestamp case class. This probably fixes d2iq-archive#1082
| @@ -15,6 +15,8 @@ case class Timestamp(dateTime: DateTime) extends Ordered[Timestamp] { | |||
| case _ => false | |||
| } | |||
|
|
|||
| override def hashCode: Int = time.hashCode | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Could you add a comment to make it explicit that we depend upon time being a UTC DateTime to uphold the equals/hashCode contract?
|
Was wondering whether it would be cleaner to move the UTC conversion into the apply constructors and turn the current UTC time into the case class parameter. case class Timestamp(utcDateTime: DateTime) extends Ordered[Timestamp]
object Timestamp {
def apply(time: String): Timestamp = Timestamp(
DateTime.parse(time).toDateTime(DateTimeZone.UTC)
)
}Then we can probably get rid of most of the overrides in the case class. |
|
@sttts, we could map the time zone in the companion's apply method. We'd also have to make the constructor private to disallow invalid instances from being built. IMO, it is quite clear as written. Let's leave a refactor out of this bugfix for a subsequent PR. |
|
Thanks! |
ConnorDoyle
added a commit
that referenced
this pull request
Feb 18, 2015
Override Timestamp hashCode for consistent hashing
|
🎊 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timestamp's hashCode was based on the parameter dateTime which might have
a timezone != UTC. The consequence:
val t = Timestamp.now
t.hashCode != Timestamp(t.toString).hashCode
This patch overrides hashCode to use the UTC normalized time variable of the
Timestamp case class.
This probably fixes #1082