This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
feat: Make containerd restart its own patch #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlipovetsky
force-pushed
the
containerd-restart
branch
from
3232a20
to
472206a
Compare
supershal
reviewed
Apr 1, 2024
supershal
reviewed
Apr 1, 2024
pkg/handlers/generic/mutation/containerdrestart/tests/generate_patches.go
Outdated
Show resolved
Hide resolved
supershal
reviewed
Apr 1, 2024
pkg/handlers/generic/mutation/containerdrestart/tests/generate_patches.go
Outdated
Show resolved
Hide resolved
supershal
reviewed
Apr 1, 2024
pkg/handlers/generic/mutation/containerdrestart/tests/generate_patches.go
Outdated
Show resolved
Hide resolved
|
This PR/issue depends on:
|
supershal
force-pushed
the
containerd-restart
branch
2 times, most recently
from
cfe0f05
to
17ce0a8
Compare
supershal
previously approved these changes
Apr 1, 2024
|
fixed unit test and rebased: 17ce0a8 |
dkoshkin
reviewed
Apr 2, 2024
dkoshkin
approved these changes
Apr 2, 2024
supershal
approved these changes
Apr 3, 2024
supershal
force-pushed
the
containerd-restart
branch
from
8e01b66
to
ec630e2
Compare
|
rebased from main after #32 was merged. |
jimmidyson
pushed a commit
that referenced
this pull request
Apr 11, 2024
* feat: Make containerd restart its own patch * fix: unit tests for kubeadmconfigtemplate with containerdrestart patch * fix: add comment for always add containerd patch * test: move unit test to their own package --------- Co-authored-by: Shalin Patel <shalin.patel@nutanix.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have multiple patches that configure containerd. We need to restart containerd after all such patches, and we should restart it exactly once.
Although we've been configuring http proxy for the containerd systemd service, we haven't been restarting it, and I believe the configuration wasn't being applied. This PR should fix that, too.
NOTE: This depends on #16 and #17, because the tests fail otherwise. Do not merge until both of these have merged.