Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

test: move all patch generator unit tests to their own packages #23

Merged
merged 8 commits into from
Apr 5, 2024

Conversation

supershal
Copy link

This PR is stacked on #21

  • Move test execution of region and HTTProxy from Meta patch handler tests. This will help with maintaining unit tests when we add more providers (i.e. Nutanix, GCP, etc..)
  • Move test execution in the same unit test file as the test cases. IMHO This will give better control over how individual tests can be run.

@supershal supershal self-assigned this Apr 3, 2024
@supershal supershal requested a review from dkoshkin April 3, 2024 18:50
@supershal supershal force-pushed the shalin/move_region_unit_test branch from 3558f8f to 2393dcc Compare April 4, 2024 17:52
@supershal supershal force-pushed the shalin/refactor_patch_tests branch from 89a8bb9 to f3883c3 Compare April 5, 2024 03:47
@supershal supershal force-pushed the shalin/move_region_unit_test branch 2 times, most recently from 71eb40c to 950eb29 Compare April 5, 2024 04:19
Base automatically changed from shalin/refactor_patch_tests to main April 5, 2024 20:37
@supershal supershal force-pushed the shalin/move_region_unit_test branch from 950eb29 to 0e3c0fb Compare April 5, 2024 20:43
* test: move instanceprofile tests to its own package

* test: move instancetype unit tests to its own package

* test: move ami unit tests to its own package

* test: move aws network tests to its own package

* test: move controlplaneloadbalancer unit tests to its own package

* test: move aws cni unit tests to its own package

* test: fix linting errors

* test: unit tests for AWS security groups
* test: move controlplane endpoint unit tests

* test: move PC endpoint unit tests

* test: nove machinedetails unit tests
@supershal supershal force-pushed the shalin/move_region_unit_test branch from e413d47 to c662b02 Compare April 5, 2024 21:12
* test: move audit policy tests to their own package

* test: move etcd unit tests to their own package

* test: move extra api server cert sans to its own package

* test: move image registry unit tests to its own package

* test: move kubernetes image repository unit tests

* test: move mirror unit tests

* test: move users unit tests

* test: remove gereric unit tests from nutanix meta patch handler

* test: cleaned up meta level unit test suites
@supershal supershal changed the title test: move region and httpproxy patch generator unit test invocation test: move all patch generator unit test invocation to their own packages Apr 5, 2024
@supershal supershal changed the title test: move all patch generator unit test invocation to their own packages test: move all patch generator unit tests to their own packages Apr 5, 2024
@supershal
Copy link
Author

in any case, if we want to revert these changes, we can revert #21 and this PR (#23)

@supershal supershal merged commit 184e7d6 into main Apr 5, 2024
19 of 22 checks passed
@supershal supershal deleted the shalin/move_region_unit_test branch April 5, 2024 21:34
@github-actions github-actions bot mentioned this pull request Apr 5, 2024
jimmidyson pushed a commit that referenced this pull request Apr 11, 2024
* test: unit test for individual patch generator

* test: package level unit test for HTTPProxy

* test: move region and httpproxy patch generator unit test invocation

* fix: linting errors

* test: move all AWS patch unit tests to their own packages (#24)

* test: move instanceprofile tests to its own package

* test: move instancetype unit tests to its own package

* test: move ami unit tests to its own package

* test: move aws network tests to its own package

* test: move controlplaneloadbalancer unit tests to its own package

* test: move aws cni unit tests to its own package

* test: fix linting errors

* test: unit tests for AWS security groups

* test: move customimage unit tests to their own package (#30)

* test:  move all Nutanix patch handler unit tests (#32)

* test: move controlplane endpoint unit tests

* test: move PC endpoint unit tests

* test: nove machinedetails unit tests

* test: move generic patch unit tests to own packages (#31)

* test: move audit policy tests to their own package

* test: move etcd unit tests to their own package

* test: move extra api server cert sans to its own package

* test: move image registry unit tests to its own package

* test: move kubernetes image repository unit tests

* test: move mirror unit tests

* test: move users unit tests

* test: remove gereric unit tests from nutanix meta patch handler

* test: cleaned up meta level unit test suites
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants