This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
refactor: CCM handler to be more generic for both CRS and CAAAPH #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
changed the title
faiq
reviewed
Apr 4, 2024
dkoshkin
force-pushed
the
dkoshkin/rafctor-ccm-handler-for-caaph
branch
from
4febefc
to
788bc11
Compare
|
The vulnerability will be fixed in #26, but the nix package for Go 1.22.2 has not been released yet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im working on adding CCM support for Nutanix that will use CAAAPH, renamed the function
EnsureCCMConfigMapForClusterto a more genericApply(to match the CSI providers).While working on this I also saw my IDE complaining about the stutter, so fixed that too.