Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

build: add Nutanix CSI to examples #33

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

dkoshkin
Copy link
Collaborator

@dkoshkin dkoshkin commented Apr 5, 2024

Added the csi: {} var to Nutanix examples along with the needed CSI Secret.

I will have a follow up PR with some minor fixes for this to work with the CSI driver

@dkoshkin dkoshkin self-assigned this Apr 5, 2024
@dkoshkin dkoshkin force-pushed the dkoshkin/build-add-nutanix-csi-to-examples branch from 1690395 to fd1ef4f Compare April 5, 2024 18:45
@dkoshkin dkoshkin force-pushed the dkoshkin/build-add-nutanix-csi-to-examples branch 2 times, most recently from 77c7158 to 2921a4a Compare April 5, 2024 18:57
Copy link

@supershal supershal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. just two fixes needed.

@dkoshkin dkoshkin requested review from supershal and faiq April 5, 2024 19:07
@dkoshkin dkoshkin force-pushed the dkoshkin/build-add-nutanix-csi-to-examples branch from 2921a4a to b9c569c Compare April 5, 2024 19:14
@dkoshkin dkoshkin force-pushed the dkoshkin/build-add-nutanix-csi-to-examples branch from b9c569c to 6d09be8 Compare April 5, 2024 21:11
Copy link

@deepakm-ntnx deepakm-ntnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any docs update required?

@dkoshkin dkoshkin merged commit e78e6f9 into main Apr 9, 2024
13 of 16 checks passed
@dkoshkin dkoshkin deleted the dkoshkin/build-add-nutanix-csi-to-examples branch April 9, 2024 15:29
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants