Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cambridge latex style resources #2187

Merged
merged 29 commits into from
Aug 4, 2022
Merged

Conversation

cheungdaven
Copy link
Member

@cheungdaven cheungdaven commented Jul 6, 2022

Description of changes:

(1) Rewrite some sphinx default latex functions and styles.
(2) The cambridge latex style is downloaded automatically. Here, I photoshopped two images (included in latex_style directory) based on alex's suggestions.
(3) The d2l-ai/d2l-book#56 of d2l-book is dependent on this pr.

To ensure the smoothness of the qr code generation process, please do not use any special characters in the URL, otherwise, it won't go through. You can easily replace the special characters with URL encoding. please refer to: https://www.urlencoder.io/learn/

To use this style, please specify the style in the config.ini of d2l-en.
style = cambridge

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

@cheungdaven cheungdaven requested a review from astonzhang July 6, 2022 00:24
@astonzhang
Copy link
Member

Since the current d2lbook does not support d2lbook build pdf --style, could you specify the dependency PR in d2lbook, if any?

@d2l-bot
Copy link
Member

d2l-bot commented Jul 6, 2022

Job d2l-en/PR-2187/1 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@cheungdaven
Copy link
Member Author

Since the current d2lbook does not support d2lbook build pdf --style, could you specify the dependency PR in d2lbook, if any?

This pr depends on PR56 of the d2lbook repository.

@d2l-bot
Copy link
Member

d2l-bot commented Jul 6, 2022

Job d2l-en/PR-2187/2 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@cheungdaven
Copy link
Member Author

@astonzhang Now all cambridge latex resources are downloaded and extracted through the S3 link.

@d2l-bot
Copy link
Member

d2l-bot commented Jul 8, 2022

Job d2l-en/PR-2187/3 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@d2l-bot
Copy link
Member

d2l-bot commented Jul 8, 2022

Job d2l-en/PR-2187/4 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@astonzhang astonzhang self-assigned this Jul 8, 2022
@d2l-bot
Copy link
Member

d2l-bot commented Jul 8, 2022

Job d2l-en/PR-2187/6 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@d2l-bot
Copy link
Member

d2l-bot commented Jul 15, 2022

Job d2l-en/PR-2187/7 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@d2l-bot
Copy link
Member

d2l-bot commented Jul 15, 2022

Job d2l-en/PR-2187/8 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@d2l-bot
Copy link
Member

d2l-bot commented Jul 15, 2022

Job d2l-en/PR-2187/10 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@d2l-bot
Copy link
Member

d2l-bot commented Jul 15, 2022

Job d2l-en/PR-2187/11 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@d2l-bot
Copy link
Member

d2l-bot commented Jul 15, 2022

Job d2l-en/PR-2187/9 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@d2l-bot
Copy link
Member

d2l-bot commented Jul 28, 2022

Job d2l-en/PR-2187/12 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

Avoid editing sphinx.sty, changes are moved to sphinx_template.py of d2lbook.
it is not necessary for now.
@d2l-bot
Copy link
Member

d2l-bot commented Aug 3, 2022

Job d2l-en/PR-2187/13 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@d2l-bot
Copy link
Member

d2l-bot commented Aug 3, 2022

Job d2l-en/PR-2187/14 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@d2l-bot
Copy link
Member

d2l-bot commented Aug 3, 2022

Job d2l-en/PR-2187/15 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@d2l-bot
Copy link
Member

d2l-bot commented Aug 3, 2022

Job d2l-en/PR-2187/16 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@d2l-bot
Copy link
Member

d2l-bot commented Aug 3, 2022

Job d2l-en/PR-2187/17 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

config.ini Outdated

latex_logo = static/logo.png
main_font = Source Serif Pro
sans_font = Source Sans Pro
mono_font = Inconsolata

bibfile = d2l.bib
style = default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add new entries latex_url and style to https://github.com/d2l-ai/d2l-book/blob/master/d2lbook/config_default.ini? Please set style = default in config_default.ini so we can remove this line.

@d2l-bot
Copy link
Member

d2l-bot commented Aug 3, 2022

Job d2l-en/PR-2187/18 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@d2l-bot
Copy link
Member

d2l-bot commented Aug 3, 2022

Job d2l-en/PR-2187/19 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@d2l-bot
Copy link
Member

d2l-bot commented Aug 3, 2022

Job d2l-en/PR-2187/20 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@d2l-bot
Copy link
Member

d2l-bot commented Aug 3, 2022

Job d2l-en/PR-2187/21 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@cheungdaven
Copy link
Member Author

cheungdaven commented Aug 4, 2022

@d2l-bot please rebuild

@d2l-bot
Copy link
Member

d2l-bot commented Aug 4, 2022

Job d2l-en/PR-2187/30 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@d2l-bot
Copy link
Member

d2l-bot commented Aug 4, 2022

Job d2l-en/PR-2187/31 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2187/

@astonzhang
Copy link
Member

astonzhang commented Aug 4, 2022

Great job, thanks!
This PR has been tested with (http://ci.d2l.ai/blue/organizations/jenkins/d2l-en/detail/PR-2187/30/pipeline) and without (http://ci.d2l.ai/blue/organizations/jenkins/d2l-en/detail/PR-2187/31/) style = cambridge.

@astonzhang astonzhang merged commit bbbc9e6 into d2l-ai:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants