Fix incorrect time now in Safari iOS 8 #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Safari iOS 8, `requestAnimationFrame` is present but `performance.now` is not. So, inconsistent of time now will happen when we both rely on `time` passed in by `requestAnimationFrame` (time since navigationStart) vs Date.now() (time since epoch) in other cases.
|
Thanks for the report. I chose a slightly different fix that avoids the kludge on modern browsers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Safari iOS 8,
requestAnimationFrameis present butperformance.nowis not.So, inconsistent of time "now" will happen since we rely on both
timepassed in byrequestAnimationFrame(time since navigationStart) and Date.now() (time since epoch) in other cases.With this changeset, I am calling
performance.nowunnecessarily on mordern browsers on everywake()though 😕