Fix #48 - CSS Matrix Transformations for Independent Axis Zooming #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any opinion if this WIP should wait for |
|
Yeah, I’m deep in trying to get d3@6 released (d3/d3#3333) and that includes d3-selection@2’s removal of d3.event. I think this will likely have to wait for d3@7. But it’d be great if you wanted to continue working on this in parallel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First steps towards implementing v2 fix of #48. Currently passes all matrix math tests, but I need to work on the gestures further. The orginal wheel and mousedown are a difficult to reason about - any help would be appreciated.
I've also noticed d3/d3-selection#210 Selection v2 is in development, I believe primarily the event global would be changed. Should we take the new event structure into consideration for this update?