Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D4rkPlayerOptimizer crashes VRCConstraint #123

Closed
QueenOfFrance opened this issue Sep 10, 2024 · 5 comments
Closed

D4rkPlayerOptimizer crashes VRCConstraint #123

QueenOfFrance opened this issue Sep 10, 2024 · 5 comments

Comments

@QueenOfFrance
Copy link

After several hours spent with the creator and developer of VRCFury trying to understand where the bug was coming from or if the constraints were not working, we only concluded that D4rkPlayerOptimizer is crashing the VRCContraint
As a solution to crossing the fence! disable “Remove unused components”

@QueenOfFrance QueenOfFrance changed the title D4rk Optimizer crashes an avatar's constraints! D4rkPlayerOptimizer crashes VRCConstraint Sep 10, 2024
@SenkyDragon
Copy link

SenkyDragon commented Sep 10, 2024

FindAllPhysBoneDependencies considers unity constraints but not vrc constraints. Not certain this is the root cause, but it's likely.

@d4rkc0d3r
Copy link
Owner

FindAllPhysBoneDependencies ofc needs fixing but I find it unlikely this is causing a crash. All it should do is accidentally delete physbones if the only effect they have is moving transforms that are exclusively used by VRCConstraints and nothing else.

@SenkyDragon
Copy link

They weren't actually receiving a crash. Your description matches the issue that was occuring. It's relatively common for creators to use a set of false bones for a renderer, and then constrain those bones between different physbones so they can animate between the two smoothly (since you can't animate physbone properties smoothly)

@d4rkc0d3r
Copy link
Owner

If thats the case, putting the affected phys bones into the exclusion list would also work until the patch goes live.

@d4rkc0d3r
Copy link
Owner

3.9.0 is out and fixes this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants