Remove bugsnag

.github/workflows/release-tag.yml

@@ -48,7 +48,6 @@ jobs:
           STORE_PASSWORD: ${{ secrets.STORE_PASSWORD }}
           KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
           KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
-          BUGSNAG_API_KEY: ${{ secrets.BUGSNAG_API_KEY }}
 
       - name: Assemble production APK
         if: "!contains(steps.tagger.outputs.tag, '-beta')"
@@ -58,7 +57,6 @@ jobs:
           STORE_PASSWORD: ${{ secrets.STORE_PASSWORD }}
           KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
           KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
-          BUGSNAG_API_KEY: ${{ secrets.BUGSNAG_API_KEY }}
 
       - name: Create pre-release
         if: contains(steps.tagger.outputs.tag, '-beta')
@@ -141,13 +139,11 @@ jobs:
           STORE_PASSWORD: ${{ secrets.STORE_PASSWORD }}
           KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
           KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
-          BUGSNAG_API_KEY: ${{ secrets.BUGSNAG_API_KEY }}
 
       - name: Assemble production and upload to Google Play
         if: "!contains(steps.tagger.outputs.tag, '-beta')"
         run: bundle exec fastlane production
         env:
           STORE_PASSWORD: ${{ secrets.STORE_PASSWORD }}
           KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
-          KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
-          BUGSNAG_API_KEY: ${{ secrets.BUGSNAG_API_KEY }}
+          KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}

PRIVACY_POLICY.md

@@ -58,6 +58,8 @@ https://support.google.com/drive/answer/10375054?hl=en
 
 ## Automatic error reports
 
+*Removed in 0.8.3*
+
 Anonymous device information may be collected in the event of an app crash or error.
 
 To do this the app uses the service "Bugsnag":
@@ -66,7 +68,8 @@ https://www.bugsnag.com/
 Bugsnag's privacy policy can be found here:
 https://docs.bugsnag.com/legal/privacy-policy/
 
-Error reports contain information related to the error that occured, your device and software versions, e.g. what happened when the error occured, your phone model, Android version and app version.
+Error reports contain information related to the error that occured, your device and software versions, e.g. what
+happened when the error occured, your phone model, Android version and app version.
 
 You can disable automatic reports in the app's settings.
 

app/build.gradle.kts

@@ -6,7 +6,6 @@ plugins {
 }
 apply(plugin = "dagger.hilt.android.plugin")
 apply(plugin = "androidx.navigation.safeargs.kotlin")
-apply(plugin = "com.bugsnag.android.gradle")
 
 android {
     val packageName = ProjectConfig.packageName
@@ -31,10 +30,6 @@ android {
         buildConfigField("String", "BUILDTIME", "\"${buildTime()}\"")
         buildConfigField("String", "VERSION_CODE", "\"${ProjectConfig.Version.code}\"")
         buildConfigField("String", "VERSION_NAME", "\"${ProjectConfig.Version.name}\"")
-
-        manifestPlaceholders["bugsnagApiKey"] = getBugSnagApiKey(
-            File(System.getProperty("user.home"), ".appconfig/${packageName}/bugsnag.properties")
-        ) ?: "fake"
     }
 
     signingConfigs {
@@ -144,9 +139,6 @@ dependencies {
     addIO()
     addRetrofit()
 
-    "gplayImplementation"("com.bugsnag:bugsnag-android:5.9.2")
-    "gplayImplementation"("com.getkeepsafe.relinker:relinker:1.4.3")
-
     addAndroidCore()
     addAndroidUI()
     addWorkerManager()

app/src/gplay/java/eu/darken/octi/common/debug/autoreport/GooglePlayReporting.kt

@@ -2,66 +2,25 @@ package eu.darken.octi.common.debug.autoreport
 
 import android.app.Application
 import android.content.Context
-import com.bugsnag.android.Bugsnag
-import com.bugsnag.android.Configuration
-import com.getkeepsafe.relinker.ReLinker
 import dagger.hilt.android.qualifiers.ApplicationContext
-import eu.darken.octi.App
-import eu.darken.octi.common.BuildConfigWrap
 import eu.darken.octi.common.InstallId
 import eu.darken.octi.common.datastore.valueBlocking
 import eu.darken.octi.common.debug.AutomaticBugReporter
-import eu.darken.octi.common.debug.Bugs
-import eu.darken.octi.common.debug.autoreport.bugsnag.BugsnagErrorHandler
-import eu.darken.octi.common.debug.autoreport.bugsnag.BugsnagLogger
-import eu.darken.octi.common.debug.autoreport.bugsnag.NOPBugsnagErrorHandler
-import eu.darken.octi.common.debug.logging.Logging
 import eu.darken.octi.common.debug.logging.log
 import eu.darken.octi.common.debug.logging.logTag
 import javax.inject.Inject
-import javax.inject.Provider
 import javax.inject.Singleton
 
 @Singleton
 class GooglePlayReporting @Inject constructor(
     @ApplicationContext private val context: Context,
     private val debugSettings: DebugSettings,
     private val installId: InstallId,
-    private val bugsnagLogger: Provider<BugsnagLogger>,
-    private val bugsnagErrorHandler: Provider<BugsnagErrorHandler>,
-    private val nopBugsnagErrorHandler: Provider<NOPBugsnagErrorHandler>,
 ) : AutomaticBugReporter {
 
     override fun setup(application: Application) {
         val isEnabled = debugSettings.isAutoReportingEnabled.valueBlocking
         log(TAG) { "setup(): isEnabled=$isEnabled" }
-
-        if (isEnabled) {
-            ReLinker
-                .log { message -> log(App.TAG) { "ReLinker: $message" } }
-                .loadLibrary(application, "bugsnag-plugin-android-anr")
-        }
-        try {
-            val bugsnagConfig = Configuration.load(context).apply {
-                if (debugSettings.isAutoReportingEnabled.valueBlocking) {
-                    Logging.install(bugsnagLogger.get())
-                    setUser(installId.id, null, null)
-                    autoTrackSessions = true
-                    addOnError(bugsnagErrorHandler.get())
-                    addMetadata("App", "buildFlavor", BuildConfigWrap.FLAVOR)
-                    log(TAG) { "Bugsnag setup done!" }
-                } else {
-                    autoTrackSessions = false
-                    addOnError(nopBugsnagErrorHandler.get())
-                    log(TAG) { "Installing Bugsnag NOP error handler due to user opt-out!" }
-                }
-            }
-
-            Bugsnag.start(context, bugsnagConfig)
-            Bugs.reporter = this
-        } catch (e: IllegalStateException) {
-            log(TAG) { "Bugsnag API Key not configured." }
-        }
     }
 
     override fun notify(throwable: Throwable) {

app/src/main/AndroidManifest.xml

@@ -41,10 +41,6 @@
             android:authorities="${applicationId}.androidx-startup"
             tools:node="remove" />
 
-        <meta-data
-            android:name="com.bugsnag.android.API_KEY"
-            android:value="${bugsnagApiKey}" />
-
         <activity
             android:name="com.journeyapps.barcodescanner.CaptureActivity"
             android:screenOrientation="sensor"

app/src/main/res/xml/preferences_acknowledgements.xml

@@ -26,15 +26,6 @@
     <PreferenceCategory
         android:title="@string/settings_licenses_label"
         app:iconSpaceReserved="false">
-        <Preference
-            android:key="license.bugsnag"
-            android:summary="Client side library for crash monitoring via bugsnag.com. (MIT)"
-            android:title="Bugsnag"
-            app:iconSpaceReserved="false">
-            <intent
-                android:action="android.intent.action.VIEW"
-                android:data="https://github.com/bugsnag/bugsnag-android" />
-        </Preference>
         <eu.darken.octi.common.preferences.IntentPreference
             android:key="license.materialdesignicons"
             android:summary="materialdesignicons.com (SIL Open Font License 1.1 / Attribution 4.0 International)"

app/src/main/res/xml/preferences_general.xml

@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
-<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android">
+<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto">
 
     <PreferenceCategory android:title="@string/settings_category_ui_label">
 
@@ -9,13 +10,16 @@
             android:title="@string/ui_theme_setting_label" />
     </PreferenceCategory>
 
-    <PreferenceCategory android:title="@string/settings_category_other_label">
+    <PreferenceCategory
+        android:title="@string/settings_category_other_label"
+        app:isPreferenceVisible="false">
 
         <CheckBoxPreference
             android:icon="@drawable/ic_spider_thread_onsurface"
             android:key="debug.bugreport.automatic.enabled"
             android:summary="Automatically reports issues, e.g. details on the app crashes so I can figure out why and fix it."
-            android:title="Automatic bug reports" />
+            android:title="Automatic bug reports"
+            app:isPreferenceVisible="false" />
 
     </PreferenceCategory>
 

app/src/main/res/xml/preferences_support.xml

@@ -27,7 +27,8 @@
             android:icon="@drawable/ic_id_onsurface"
             android:key="support.installid"
             android:summary="@string/support_installid_desc"
-            android:title="@string/support_installid_label" />
+            android:title="@string/support_installid_label"
+            app:isPreferenceVisible="false" />
         <Preference
             android:icon="@drawable/ic_baseline_bug_report_24"
             android:key="support.debuglog"

build.gradle.kts

@@ -8,7 +8,6 @@ buildscript {
         classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:${Versions.Kotlin.core}")
         classpath("com.google.dagger:hilt-android-gradle-plugin:${Versions.Dagger.core}")
         classpath("androidx.navigation:navigation-safe-args-gradle-plugin:${Versions.AndroidX.Navigation.core}")
-        classpath("com.bugsnag:bugsnag-android-gradle-plugin:7.2.1")
     }
 }
 

buildSrc/src/main/java/ProjectConfig.kt

@@ -130,14 +130,4 @@ fun com.android.build.api.dsl.SigningConfig.setupCredentials(
             keyPassword = props.getProperty("release.keyPassword")
         }
     }
-}
-
-fun getBugSnagApiKey(
-    propertiesPath: File?
-): String? {
-    val bugsnagProps = Properties().apply {
-        propertiesPath?.takeIf { it.canRead() }?.let { load(FileInputStream(it)) }
-    }
-
-    return System.getenv("BUGSNAG_API_KEY") ?: bugsnagProps.getProperty("bugsnag.apikey")
 }