cells: fix race condition between thread start and flag check #7742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: If newly started thread runs before `running` flag is set, then tunnel with shutdown instantly. Thread-1: Create T2 --> | T2.start() | --> set running flag Thread-2: | check flag; exit | Modification: set `running` before thread starts. Result: race is fixed Issue: #5326 Acked-by: Paul Millar Target: master, 10.2 Require-book: no Require-notes: yes (cherry picked from commit 2440b22) Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If newly started thread runs before
runningflag is set, then tunnel with shutdown instantly.Thread-1: Create T2 --> | T2.start() | --> set running flag
Thread-2: | check flag; exit |
Modification:
set
runningbefore thread starts.Result:
race is fixed
Issue: #5326
Acked-by: Paul Millar
Target: master, 10.2
Require-book: no
Require-notes: yes
(cherry picked from commit 2440b22)