-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addresses API changes in scikit-learn dependency #335
Conversation
@amueller tried to fix this bug so we can use dabl for some MLOS integrations for a class demo. However, the tests don't pass. But they don't pass in main right now either for me. Thoughts? |
Ideally dabl should work both with sklearn 1.1 and 1.3, which makes the fix a bit trickier. And the errors are because, well, main is supposed to run on 1.1 and not 1.3, I think? Thank you for tackling this, I haven't gotten around to it yet unfortunately. |
… supporting multiple scikit-learn versions
FWIW, the following more restricted tests still pass: pytest -x dabl/tests/test_models.py dabl/tests/test_available_if.py dabl/tests/test_utils.py dabl/tests/test_explain.py |
FWIW, my personal fork has this set of changes passing for the full suite of test versions now here: Though, that relies on changes from #336 as well to do that test. |
Adds a basic `mlos_viz.plot(exp)` style API for simple visualizations of `ExperimentData` results relative to the experiment's objectives (building off of #628 and dabl/dabl#335). Note: this PR currently omits unit tests for the new module due to the complexity of testing visualizations. We intend to add this in future PRs. There is however, a working example of its use here right now: Microsoft-CISL/sqlite-autotuning#41 --------- Co-authored-by: Sergiy Matusevych <sergiy.matusevych@gmail.com>
Closes #330
Based on changes in scikit-learn: