Skip to content

Commit

Permalink
net: keep refcount warning in reqsk_free()
Browse files Browse the repository at this point in the history
As Eric Dumazet said, "We do not have a way to tell if the req was ever
inserted in a hash table, so better play safe.".
Let's remove this comment, so that nobody will be tempted to drop the
WARN_ON_ONCE() line.

Signed-off-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Guillaume Nault authored and davem330 committed Mar 10, 2019
1 parent 1f5d861 commit 1039c6e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion include/net/request_sock.h
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ reqsk_alloc(const struct request_sock_ops *ops, struct sock *sk_listener,

static inline void reqsk_free(struct request_sock *req)
{
/* temporary debugging */
WARN_ON_ONCE(refcount_read(&req->rsk_refcnt) != 0);

req->rsk_ops->destructor(req);
Expand Down

0 comments on commit 1039c6e

Please sign in to comment.