#29 Allow async initialization of Node and Client #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
David Pilato » spring-elasticsearch #32 SUCCESS |
|
David Pilato » spring-elasticsearch #33 SUCCESS |
|
David Pilato » spring-elasticsearch #34 SUCCESS |
ghost
assigned 
|
Is it ok for you David? |
|
Hey Nicolas, I need to take time to review it properly. What do you think? I will try to add other comments early next week. Thanks for the PR! Best. |
|
You right, I have not paid attention to the XSD namespace version |
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.