Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOM descriptor contains wrong artifact names #36

Closed
bertramn opened this issue Feb 24, 2018 · 2 comments
Closed

BOM descriptor contains wrong artifact names #36

bertramn opened this issue Feb 24, 2018 · 2 comments

Comments

@bertramn
Copy link

Looks like the bom descriptor includes invalid dependencies. Lines pom.xml#L19 and pom.xml#L24 should not be jpa-unit-junitX but just jpa-unitX.

No artifact found for jpa-unit-junit4 but I can spot jpa-unit4.

Also note that using maven macro functions <groupId>${project.groupId}</groupId> and <version>${project.version}</version> in your bom will not always populate these fields with the values of your bom but with values of the importing project. It's a known issue and folks typically generate their bom without maven macro functions.

@dadrus
Copy link
Owner

dadrus commented Feb 24, 2018

Thank you @bertramn for this finding. Blame on me, I forgot to change the name in the bom after renaming the artifacts.

The fix is pretty trivial. What I am however curios about is your note about maven properties I used for groupdId and version in the bom. To be honest, I've never encountered the issue you're talking about. I also failed to find something related to it via google. Do you know some resources, I can take a closer look at to get more insights into it?

The groupId is simple, but version could introduce headaches - I would like the version for each referenced module in the bom to be updated automatically during the release. But maven-release-plugin does not support this is far as I remember. How would you address this?

@dadrus
Copy link
Owner

dadrus commented Jun 28, 2018

solved in #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants