Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

37 jpa unit rdbms extension requires the usage of #40

Merged
merged 23 commits into from
Jun 28, 2018

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Jun 28, 2018

solves #37
solves #36

@dadrus
Copy link
Owner Author

dadrus commented Jun 28, 2018

👍

Approved with PullApprove

@dadrus dadrus merged commit a06ea35 into master Jun 28, 2018
@dadrus dadrus deleted the 37-jpa-unit_rdbms_extension_requires_the_usage_of branch June 28, 2018 11:19
@groie
Copy link

groie commented Jul 16, 2018

@dadrus, my colleague told me that after this change we cannot just simply import the library - it will not be able to resolve some internal versions and it will complain about "${revision}". We'll try importing the junit4-version with a bom to see if it works that way. Regardless here might be something that blocks a release.

@dadrus
Copy link
Owner Author

dadrus commented Jul 16, 2018

If you run mvn flatten:flatten deploy (flatten is currently enabled only in the release profile), you'll get properly build artifacts in your repository with all variables and placeholders resolved. If you like, you can also add -Drevision=<0.5.0-RC> to remove SNAPSHOT from the name.

The "old" BOM was broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants