Implement daedalean-use-noexcept check #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finomen
suggested changes
Jul 15, 2022
Javier-varez
force-pushed
the
ja/noexcept
branch
from
4a0ba9c
to
608e44b
Compare
finomen
approved these changes
Jul 18, 2022
Javier-varez
force-pushed
the
ja/noexcept
branch
from
608e44b
to
e678ca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nice thing about clang-tidy checks is that they show up in clangd as well, so the user should fix missing noexcept specifiers before reaching review stage and remove some boilerplate comments/fixes from the reviews.