Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sync): fix ipversion_prefer; add logfile; support binding to wg #76

Merged
merged 10 commits into from
Jul 17, 2023

Conversation

dae-prow[bot]
Copy link
Contributor

@dae-prow dae-prow bot commented Jul 15, 2023

⏳ dae-wing (origin/main) is currently out-of-sync to dae (origin/main); changes are proposed by @daeBot in actions - https://github.com/daeuniverse/dae-wing/actions/runs/5553048363

Changelogs

#141 - fix(dns): should reject with nx instead of 0.0.0.0

Ref: daeuniverse/dae#141

Context:

The DNS rejection procedure now (reject with 0.0.0.0) causes some problems daeuniverse/dae#136; to avoid DDoS to local services like nginx listening at port 80.


#219 - feat/chore: add log file/refine code/add tip for no-load

Ref: daeuniverse/dae#219

Context:

NA


#221 - fix: support to bind dae to wg lan (and other tun)

Ref: daeuniverse/dae#221

Context:

When using the dae's bind-lan functionality, the binding fails to work properly when attempting to bind a WireGuard interface. As a result, the traffic from the WireGuard interface is not being routed through the dae proxy.

See more #191.


#225 - fix(ebpf): udp problem caused by #221 by accident

Ref: daeuniverse/dae#225

Context:

In #221, I incorrectly parse UDP header as TCP header, which causes a failure in parsing five tuples and results in bad connectivity of UDP.


piyoki
piyoki previously approved these changes Jul 15, 2023
@mzz2017 mzz2017 changed the title chore(sync): keep upstream source up-to-date chore(sync): fix dns; add logfile Jul 16, 2023
@mzz2017 mzz2017 changed the title chore(sync): fix dns; add logfile chore(sync): fix ipversion_prefer; add logfile Jul 16, 2023
@mzz2017
Copy link
Contributor

mzz2017 commented Jul 16, 2023

Some work to do before merging it.

@mzz2017
Copy link
Contributor

mzz2017 commented Jul 16, 2023

TODO List:

  • Add ipversion_prefer support. // Already support. No need to add.
  • Add logfile support.

@kunish
Copy link
Member

kunish commented Jul 16, 2023

TODO List:

  • Add ipversion_prefer support.
  • Add logfile support.

You may want to convert this PR as a DRAFT before these todos get resolved

@mzz2017 mzz2017 marked this pull request as draft July 17, 2023 12:55
@mzz2017 mzz2017 changed the title chore(sync): fix ipversion_prefer; add logfile chore(sync): fix ipversion_prefer; add logfile; support bind to wg Jul 17, 2023
@mzz2017 mzz2017 changed the title chore(sync): fix ipversion_prefer; add logfile; support bind to wg chore(sync): fix ipversion_prefer; add logfile; support binding to wg Jul 17, 2023
@mzz2017 mzz2017 marked this pull request as ready for review July 17, 2023 13:23
@mzz2017
Copy link
Contributor

mzz2017 commented Jul 17, 2023

Ready for review.

Copy link
Member

@kunish kunish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Brainer

@kunish
Copy link
Member

kunish commented Jul 17, 2023

Lets ship it!

@mzz2017 mzz2017 merged commit 9b8aaf6 into main Jul 17, 2023
@mzz2017 mzz2017 deleted the sync-upstream branch July 17, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants