fix: should allow fallbacking ip version if dialing domain #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzz2017
changed the title
|
![dae-prow[bot]](https://avatars.githubusercontent.com/in/345419?s=60&v=4){kind=small}
|
|
|
|
|
@MarksonHon LGTM. Thanks bro. |
This was referenced Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
If the local host has IPv6 addresses but the remote proxy does not,
daedrops all the IPv6 traffic onto the remote proxy. This behavior impacts lots of software that does not support happy eyeballs.In fact, if we send the domain to the remote proxy, it will re-select ip version and this problem will be resolved.
In the past,
daedid not support domain sniffing. The developer hope to solve this problem by happy eyeballs, but now it seems that this change needs to be optimized, and only when dialing ip instead, maintain the previous behavior.Checklist
Full changelogs
dial_modeis notip, dae removes notifying the kernel program to block the unreachable triples (group, ip version, l4 protocol).dialtarget is not an ip, dae trys to fallback to another ip version to dial.Issue reference
Fix #152