Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(trigger): separate pr_build from build #183

Merged
merged 11 commits into from
Jul 8, 2023
Merged

ci(trigger): separate pr_build from build #183

merged 11 commits into from
Jul 8, 2023

Conversation

piyoki
Copy link
Contributor

@piyoki piyoki commented Jul 8, 2023

Background

As part of the roadmap mentioned in #156, this PR includes proposed changes to separate pr-based events from the build workflow. As a result, the ONLY difference is the trigger. In order to move forward to achieving CI modularity, this PR is necessary.

Checklist

Full changelogs

  • docs(README): add build status badge
  • ci(trigger): separate pr_build from build
  • ci: add run_name followed by #pr_number - pr_title @pr_ref:pr_sha
  • ci: add initial job to show pr context
  • ci: run build job after context job

Issue reference

As part of #156

Test Result

Ref: https://github.com/daeuniverse/dae/actions/runs/5494674099

image

@piyoki piyoki added test and removed not-yet-tested labels Jul 8, 2023
@piyoki
Copy link
Contributor Author

piyoki commented Jul 8, 2023

Ready for review.

@mzz2017
Copy link
Contributor

mzz2017 commented Jul 8, 2023

LGTM~

@piyoki piyoki added tested and removed test labels Jul 8, 2023
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@piyoki piyoki merged commit b8660fd into main Jul 8, 2023
@piyoki piyoki deleted the pr_build branch July 8, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants