Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dns): replace dnsmessage with miekg/dns #188

Merged
merged 2 commits into from
Jul 9, 2023
Merged

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jul 9, 2023

Background

image

golang.org/x/net/dns/dnsmessage has limited RFC support and slower evolution. This PR replaces it with https://github.com/miekg/dns to try to fix potential problems.

Checklist

Full changelogs

@piyoki
Copy link
Contributor

piyoki commented Jul 9, 2023

CleanShot 2023-07-09 at 16 00 28@2x

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit 00cf4bc into main Jul 9, 2023
@mzz2017 mzz2017 deleted the fix_dns_err branch July 9, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants