Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(pr-build): don't trigger workflow for draft PRs #215

Merged
merged 2 commits into from
Jul 14, 2023
Merged

ci(pr-build): don't trigger workflow for draft PRs #215

merged 2 commits into from
Jul 14, 2023

Conversation

piyoki
Copy link
Contributor

@piyoki piyoki commented Jul 14, 2023 •
edited
Loading

Background

Do not trigger pr-build workflow for draft PRs

Checklist

Full changelogs

  • ci(pr-build): don't trigger workflow for draft PRs

Issue reference

NA

Test Result

CleanShot 2023-07-14 at 11 40 35@2x CleanShot 2023-07-14 at 11 41 18@2x

@piyoki piyoki requested a review from mzz2017 as a code owner July 14, 2023 03:36
@piyoki piyoki marked this pull request as draft July 14, 2023 03:39
mzz2017
mzz2017 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@piyoki
Copy link
Contributor Author

piyoki commented Jul 14, 2023 •
edited
Loading

@mzz2017 As a result (see in PR description), PRs in draft will NOT trigger the pr-build workflow.

@piyoki piyoki marked this pull request as ready for review July 14, 2023 03:43
@piyoki piyoki merged commit f5fce5c into main Jul 14, 2023
@piyoki piyoki deleted the hotfix/draft_pr_build branch July 14, 2023 03:43
@piyoki piyoki mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzz2017 mzz2017 mzz2017 approved these changes

Assignees

@piyoki piyoki

Labels
ci priority/high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piyoki @mzz2017