Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: fix subscription pulling panic caused by #233 #237

Merged
merged 1 commit into from
Jul 24, 2023
Merged

hotfix: fix subscription pulling panic caused by #233 #237

merged 1 commit into from
Jul 24, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jul 24, 2023 •
edited
Loading

Background

image

Checklist

Full changelogs

  • Add back lost client.Do(req).

Test Result

image

@mzz2017 mzz2017 requested a review from a team as a code owner July 24, 2023 13:52
dae-prow[bot]
dae-prow bot approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit 3274b30 into main Jul 24, 2023
@mzz2017 mzz2017 deleted the fix_subscription_panic branch July 24, 2023 13:54
@dae-prow dae-prow bot mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyoki piyoki piyoki approved these changes

@dae-prow dae-prow[bot] dae-prow[bot] approved these changes

Assignees

@mzz2017 mzz2017

Labels
hotfix tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzz2017 @piyoki