Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: force to choose one if there is only one node in the group #251

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Aug 1, 2023

Background

Should fallback to fixed(0) if there is only one node in this group and even if it not alive.

Checklist

Full changelogs

  • Change the logic in node select.

Issue reference

N/A

Test Result

N/A

@mzz2017 mzz2017 requested a review from a team as a code owner August 1, 2023 18:26
@mzz2017 mzz2017 requested a review from kunish August 1, 2023 18:26
@mzz2017 mzz2017 changed the title optimize: force to choose if there is only one node in the group optimize: force to choose one if there is only one node in the group Aug 2, 2023
@dae-prow
Copy link
Contributor

dae-prow bot commented Aug 2, 2023

❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you.

@mzz2017
Copy link
Contributor Author

mzz2017 commented Aug 2, 2023

Test Result:
image

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit e5d3f5b into main Aug 3, 2023
@mzz2017 mzz2017 deleted the optimize_force_choose_one_node_group branch August 3, 2023 13:16
mzz2017 added a commit that referenced this pull request Aug 5, 2023
mzz2017 added a commit that referenced this pull request Aug 5, 2023
* fix: bad ipversion selection caused by #251

* chore: upgrade softwind
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants