refactor/fix: match dscp instead of tos #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you. |
mzz2017
changed the title
|
Test Result: |
![dae-prow[bot]](https://avatars.githubusercontent.com/in/345419?s=60&v=4){kind=small}
|
Test Result 2 (tcp, ipv6): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
A problem was introduced in #292. This is because we added
dscpas a member ofstruct tuples. However,struct tuplesis used for five tuples matching. Whendscpis added, packets with the non-zero dscp will be rejected due to matching failures. This problem impacts packets unmatched in eBPF programs.Another change is that, we should match dscp instead of tos.
See #295
Checklist
Full Changelogs
Issue Reference
Closes #[issue number]
Test Result