-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize(udp)/fix(quicSniffer): optimize performance of udp and fix a potential panic of quic #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧪 Since the PR has been fully tested, please consider merging it.
Hold it. We need to improve the stream sniffer instead of just skip the problem. I'll convert it into a draft. |
❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you. |
Ready for review. |
❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you. |
Sniffing should work fine now. Please test it again, thanks. |
❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you. |
TCP is working as expected. However, there is a noticeable speed discrepancy in UDP connection. Let’s gather more feedbacks from the end-users. |
https://t.me/daeuniverse/119500 It is recommended to merge in advance. |
cc @yqlbu |
Ok, let's do so. However, we shall make an announcement in the next release as this is a known issue. |
Link to #355 |
… potential panic of quic (daeuniverse#301)
Background
Fix panic
When a quic first packet is insufficient, the re-assembler will panic due to being out of range. This PR fixes it.
Support cross-packet reassembling for QUIC (SNI Sniff)
After this quic cross-packet reassembling, we can get SNI in more cases. However, quic connecting to google servers seems to be refused if the destination is overridden. Therefore, we can only use the quic sniffed domain for routing instead of dest overriding.
UDP Performance
And this PR improves UDP performance.
Before:
After:
Checklist
Full Changelogs
Issue Reference
Closes #343
Test Result