Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch(pkg/logger): use local system timezone #328

Closed
wants to merge 3 commits into from

Conversation

piyoki
Copy link
Contributor

@piyoki piyoki commented Sep 10, 2023

Background

Use the host's system timezone instead of UTC.

Checklist

Full Changelogs

  • patch(pkg/logger): use local system timezone
  • fixture(pkg/logger): add unit test

Issue Reference

Closes #326

Test Result

◆ dae git:(timezone_based_logger) ✗ ❯❯❯ go test -v ./pkg/logger/ -run TestLogger            01:21:01
=== RUN   TestLogger
time="Sep 11 01:21:02" level=info msg="Hi there!"
--- PASS: TestLogger (0.00s)
PASS
ok      github.com/daeuniverse/dae/pkg/logger   0.002s

Unit Test

CleanShot 2023-09-11 at 01 22 12@2x

Actual behavior test

image

@piyoki piyoki requested a review from a team as a code owner September 10, 2023 17:29
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@piyoki
Copy link
Contributor Author

piyoki commented Oct 19, 2023

According to the actual test:

CleanShot 2023-10-19 at 10 20 23@2x

@EkkoG
Copy link
Contributor

EkkoG commented Oct 19, 2023

This change is no needed, see #345

@piyoki
Copy link
Contributor Author

piyoki commented Oct 19, 2023

Marked as resolved. See comments above.

@piyoki piyoki closed this Oct 19, 2023
@piyoki piyoki deleted the timezone_based_logger branch October 19, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support use system timezone or set timezone when log
2 participants