Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: refine DNS example #329

Merged
merged 1 commit into from
Oct 21, 2023
Merged

docs: refine DNS example #329

merged 1 commit into from
Oct 21, 2023

Conversation

EkkoG
Copy link
Contributor

@EkkoG EkkoG commented Sep 11, 2023 •
edited
Loading

Background

Since qname condition is more slow than ip condition, so the DNS example should move the ip condition to the start, for most DNS request, it will only need check if IP is private.

Checklist

Full Changelogs

  • Refine DNS example, better performance

Issue Reference

no

Test Result

no

@EkkoG EkkoG requested review from a team as code owners September 11, 2023 06:10
@dae-prow dae-prow bot assigned EkkoG Sep 11, 2023
@dae-prow dae-prow bot added the documentation Improvements or additions to documentation label Sep 11, 2023
mzz2017
mzz2017 approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzz2017 mzz2017 merged commit 49be5c7 into daeuniverse:main Oct 21, 2023
@mzz2017
Copy link
Contributor

mzz2017 commented Oct 21, 2023

Thanks for your insightful catch.

@dae-prow dae-prow bot mentioned this pull request Oct 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzz2017 mzz2017 mzz2017 approved these changes

Assignees

@EkkoG EkkoG

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EkkoG @mzz2017