Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add zsh completion #353

Merged
merged 1 commit into from
Nov 15, 2023
Merged

chore: add zsh completion #353

merged 1 commit into from
Nov 15, 2023

Conversation

st0nie
Copy link
Contributor

@st0nie st0nie commented Nov 5, 2023

install:

install -m644 ./install/shell-completion/dae.zsh /usr/share/zsh/site-functions/_dae

Background

Checklist

Test Result

image
image
image

@st0nie st0nie requested a review from a team as a code owner November 5, 2023 15:50
@dae-prow dae-prow bot assigned st0nie Nov 5, 2023
@dae-prow dae-prow bot added the chore label Nov 5, 2023
piyoki
piyoki previously approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@piyoki piyoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature, thanks!

@piyoki piyoki added the tested label Nov 6, 2023
dae-prow[bot]
dae-prow bot previously approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@piyoki piyoki requested a review from mzz2017 November 6, 2023 13:38
@st0nie st0nie requested a review from piyoki November 9, 2023 13:28
@st0nie st0nie marked this pull request as draft November 9, 2023 13:29
@st0nie st0nie dismissed stale reviews from dae-prow[bot] and piyoki via fd10006 November 9, 2023 13:46
@st0nie st0nie marked this pull request as ready for review November 9, 2023 13:46
@st0nie
chore: add zsh completion
92dfcab 
install:

```sh
install -m644 ./install/shell-completion/dae.zsh /usr/share/zsh/site-functions/_dae
```

Signed-off-by: ston <ston.jia@qq.com>
@mzz2017 mzz2017 merged commit dedc716 into daeuniverse:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyoki piyoki piyoki approved these changes

@dae-prow dae-prow[bot] dae-prow[bot] left review comments

@mzz2017 mzz2017 Awaiting requested review from mzz2017

Assignees

@st0nie st0nie

Labels
chore tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@st0nie @piyoki @mzz2017